-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(python): Add make docs
command, DataType docs/layout tweak, minor README updates
#15386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
March 29, 2024 07:07
github-actions
bot
added
documentation
Improvements or additions to documentation
python
Related to Python Polars
rust
Related to Rust Polars
labels
Mar 29, 2024
alexander-beedie
changed the title
docs: Add
docs: Add Mar 29, 2024
make docs
command, minor page/datatype layout tweakmake docs
command, datatype docs/layout tweak, minor README updates
alexander-beedie
force-pushed
the
misc-docs
branch
from
March 29, 2024 07:15
ba0dc7c
to
13d9152
Compare
alexander-beedie
changed the title
docs: Add
docs: Add Mar 29, 2024
make docs
command, datatype docs/layout tweak, minor README updatesmake docs
command, DataType docs/layout tweak, minor README updates
stinodego
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely happy with the new make commands 👍 . Not so sure about a lot of the other changes.
@stinodego can this go in now? |
stinodego
approved these changes
Apr 3, 2024
stinodego
changed the title
docs: Add
docs(python): Add Apr 3, 2024
make docs
command, DataType docs/layout tweak, minor README updatesmake docs
command, DataType docs/layout tweak, minor README updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of minor docs-related updates:
make docs
(incremental) andmake docs-clean
(full rebuild) commands to the regular py-polars Makefile; has always been something of a minor irritation having to remember tocd
into a different directory to do this, issue the relevantmake
command, and then have tocd
back.String
-related types (eg: inc.Enum
andCategorical
) are now bundled together under "String" instead of ending up in the miscellaneous grab-bag of "Other" (string types are important).README
to "Using custom Rust functions in Python" as it shouldn't really come across as a question (or a singular "function").README
and added a couple of the more important missing ones.